Skip to content

Conversation

@hovu96
Copy link
Contributor

@hovu96 hovu96 commented Oct 29, 2025

Summary

The --restart-recipes flag allows restarting of running recipes that are updated during import, but does not force stopped recipes to restart. This was not clear from the help text and documentation, leading to confusion about the expected behavior.

Changes

  • Breaking change: Changed default from true to false (more conservative approach)
  • Updated help text to clarify that stopped recipes remain stopped
  • Added inline comments in documentation (COMMAND_REFERENCE.md and USE_CASES.md)
  • Updated test to reflect new default value

Behavior

Before: workato push would allow recipe restarts by default
After: workato push will NOT allow recipe restarts by default

Users who want to allow restarts must now explicitly use:

workato push --restart-recipes

This aligns with the Workato API's default behavior and makes the CLI more conservative by default.

Testing

  • ✅ All unit tests pass
  • ✅ Ruff linter passed
  • ✅ Mypy type checker passed

🤖 Generated with Claude Code

The --restart-recipes flag allows restarting of running recipes that are
updated during import, but does not force stopped recipes to restart. This
was not clear from the help text and documentation.

Changes:
- Changed default from true to false (breaking change - more conservative)
- Updated help text to clarify that stopped recipes remain stopped
- Added inline comments in documentation to explain behavior
- Updated test to reflect new default value

Users who want to allow recipe restarts must now explicitly use:
  workato push --restart-recipes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py68494%10–11, 69–70
cli
   __init__.py52394%49, 51, 60
   containers.py270100% 
cli/commands
   __init__.py00100% 
   api_clients.py286996%24, 297, 442–443, 476, 486, 576, 607, 615
   api_collections.py253398%25, 178, 340
   assets.py46295%51–52
   connections.py520599%582, 584, 590, 628, 977
   data_tables.py163596%28, 248, 262, 316–317
   guide.py166199%106
   init.py890100% 
   profiles.py1970100% 
   properties.py95198%18
   pull.py171298%190–191
   workspace.py38294%57, 67
cli/commands/connectors
   __init__.py00100% 
   command.py88297%105, 154
   connector_manager.py203498%176, 292, 300–301
cli/commands/projects
   __init__.py00100% 
   command.py2691096%353–356, 367, 433–435, 485, 489
   project_manager.py166795%48, 66, 263–264, 276, 317, 325
cli/commands/push
   __init__.py00100% 
   command.py132496%105, 108, 226, 304
cli/commands/recipes
   __init__.py00100% 
   command.py423997%113, 129–130, 267–270, 397, 703
   validator.py7062097%174, 883, 1136, 1223, 1246, 1279, 1281–1282, 1359–1361, 1457–1458, 1517–1518, 1707–1708, 1736–1738
cli/utils
   __init__.py30100% 
   exception_handler.py198696%137, 184, 211, 238, 295, 330
   gitignore.py140100% 
   ignore_patterns.py230100% 
   spinner.py430100% 
   version_checker.py135695%24, 26, 33–34, 72, 102
cli/utils/config
   __init__.py50100% 
   manager.py4671995%125, 136–138, 141, 154, 204–205, 357, 438–439, 478, 692, 835–836, 850–851, 912, 971
   models.py330100% 
   profiles.py3091096%93, 189–190, 193, 228–230, 255–257
   workspace.py680100% 
TOTAL545613497% 

@hovu96 hovu96 self-assigned this Oct 29, 2025
@hovu96 hovu96 requested review from cmworkato and oalami October 29, 2025 09:29
@oalami oalami requested a review from Copilot October 30, 2025 20:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the default behavior of the --restart-recipes flag in the push command from True to False, making recipe restart an opt-in feature rather than opt-out. The help text is also updated to clarify that the flag only allows restarting of running recipes that were updated, while stopped recipes remain stopped.

Key Changes

  • Changed --restart-recipes default from True to False in the push command
  • Updated help text to clarify that the flag allows restarting running recipes, and stopped recipes remain stopped
  • Updated test expectations to align with the new default value
  • Updated documentation to reflect the new default behavior and add clarifying comments

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/workato_platform_cli/cli/commands/push/command.py Changed --restart-recipes default to False and updated help text to clarify behavior
tests/unit/commands/push/test_command.py Updated test assertion to expect False as default value for restart_recipes
docs/USE_CASES.md Added comments clarifying that --restart-recipes only restarts running recipes
docs/COMMAND_REFERENCE.md Updated documentation to note recipes won't restart by default and clarified behavior; fixed trailing whitespace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@oalami oalami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oalami oalami merged commit 896232d into main Oct 30, 2025
11 checks passed
@oalami oalami deleted the fix/clarify-restart-recipes-flag-semantics branch October 30, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants